Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seed argument #431

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Remove seed argument #431

merged 5 commits into from
Oct 4, 2024

Conversation

gowerc
Copy link
Collaborator

@gowerc gowerc commented Sep 27, 2024

Closes #415

gravesti
gravesti reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments :) @gowerc

data-raw/create_print_test_data.R Outdated Show resolved Hide resolved
tests/testthat/test-mcmc.R Outdated Show resolved Hide resolved
R/methods.R Outdated Show resolved Hide resolved
@gowerc
Copy link
Collaborator Author

gowerc commented Sep 30, 2024

@gravesti - TY those all look reasonable so have applied them all

gravesti
gravesti approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@gravesti gravesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @gowerc

@gowerc
Copy link
Collaborator Author

gowerc commented Oct 1, 2024

@gravesti - The only thing on my mind is whether the warning for using the seed argument should be upgraded to an error ? As in currently I've completely removed the functionality so using the seed= argument does nothing so perhaps it is misleading for the program to only throw a warning ? Or at least maybe I should make the warning more explicit ?

@gravesti
Copy link
Collaborator

gravesti commented Oct 1, 2024

Yeah, it's a bit in the middle now. One way would have been to throw a warning but still set the seed. However now that you're removed the functionality, I agree it might be better to go straight to error, since not setting the seed properly in analysis code will create worse problems.

@gowerc
Copy link
Collaborator Author

gowerc commented Oct 4, 2024 •
edited
Loading

@gravesti - Ok upgraded to an error - Please can you reapprove ?

@gowerc gowerc merged commit c6d0b82 into main Oct 4, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gravesti gravesti gravesti approved these changes

Assignees

@gravesti gravesti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove seed argument for method_bayes
2 participants
@gowerc @gravesti