Add two example apps to showcase DDL and Custom transformation #177
Conversation
| nest_logo <- "https://raw.githubusercontent.com/insightsengineering/hex-stickers/main/PNG/nest.png" | ||
| app_source <- "https://github.com/insightsengineering/teal.gallery/tree/main/basic-teal" | ||
| gh_issues_page <- "https://github.com/insightsengineering/teal.gallery/issues" | ||
|
|
||
| header <- tags$span( | ||
| style = "display: flex; align-items: center; justify-content: space-between; margin: 10px 0 10px 0;", | ||
| tags$span("Teal app with custom transform", style = "font-size: 30px;"), | ||
| tags$span( | ||
| style = "display: flex; align-items: center;", | ||
| tags$img(src = nest_logo, alt = "NEST logo", height = "45px", style = "margin-right:10px;"), | ||
| tags$span(style = "font-size: 24px;", "NEST @ Roche") | ||
| ) | ||
| ) | ||
|
|
||
| footer <- tags$p( | ||
| "This teal app is brought to you by the NEST Team at Roche/Genentech. | ||
| For more information, please visit:", | ||
| tags$a(href = app_source, target = "_blank", "Source Code"), ", ", | ||
| tags$a(href = gh_issues_page, target = "_blank", "Report Issues") | ||
| ) |
There was a problem hiding this comment.
This is not a comment for this PR, but all apps code is extended by 20 lines just to add a NEST logo
general issue here: #178
| ), | ||
| modules = modules( | ||
| example_module("Module with transformations", transformers = my_transformers), | ||
| example_module("Module with only iris transformation", transformers = my_transformers[1]), |
There was a problem hiding this comment.
is it really needed?
| example_module("Module with only iris transformation", transformers = my_transformers[1]), |
There was a problem hiding this comment.
I think it's okay to have this. Without this, we would have one module with transformers and one without it. Adding a transformation using the same object clears some misconceptions some people might have. For example, the my_transformers object can be used only once. It's an example to show that transformers are stacked and more importantly it shows that you have to pass transformers as a list and not a teal_transform_module object even when you have a single transform.
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
Co-authored-by: Dawid Kałędkowski <[email protected]> Signed-off-by: Vedha Viyash <[email protected]>
vedhav
force-pushed
the
669_insertUI@dev
branch
from
184dd46
to
929f2df
Compare
| @@ -78,7 +93,7 @@ jobs: | |||
| - name: Checkout repo 🛎 | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| ref: "${{ env.BRANCH_NAME }}" | |||
| ref: "669_insertUI@dev" | |||
There was a problem hiding this comment.
| ref: "669_insertUI@dev" | |
| ref: "${{ env.BRANCH_NAME }}" |
Should revert the branch checkout before merging. This was changed just to test the deployment.
vedhav
force-pushed
the
669_insertUI@dev
branch
from
a57d8fc
to
91d4179
Compare
vedhav
force-pushed
the
669_insertUI@dev
branch
from
5fc88d1
to
563be2e
Compare
|
Both the custom-transform and delayed-data apps are deployed on |
|
@vedhav Is it possible to make the output of the custom-transform a bit more customized so that the output panel is more insightful when merging |
|
Sure @kumamiao, thanks for the idea!
2. Do you want to sort the column names for select options or leave them in the same order as the datasets?
|
Adds
delayed-dataandcustom-transformapp.Note that it will take a while for this branch to be merged to the main depending on the release of the
teal_transform_modulefeature.Additionally, after the UI-refactor the apps have to be re-recorded.