Fix failed pipeline

[donyunardi]

Fixes #284

Small note, I ended up using testthat::skip_if_not_installed("ggplot2") at the beginning of several unit test files (e.g., test-DownloadReportModule.R, test-LoadReporterModule.R, etc.) because they depend on ggplot2 at the start of the test.

I don't think this update will affect our code coverage since code coverage is done using a different workflow (Check) which I believe will install all dependencies, including ggplot2.

[github-actions]

✅ All contributors have signed the CLA
_{Posted by the CLA Assistant Lite bot.}

[donyunardi]

I have read the CLA Document and I hereby sign the CLA

[github-actions]

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d71c75d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   18 suites   33s ⏱️
189 tests 189 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit d71c75d.

♻️ This comment has been updated with latest results.

[donyunardi]

Scheduled workflow passed:
https://github.com/insightsengineering/teal.reporter/actions/runs/10586868417

[m7pr]

ggplot2 is in Suggests so such a workaround with skip_if_not_installed() is recommended.

Few points:

• I don't understand the addition of rmarkdown to VignetteBuilder honestly and for now I don't think it should be there.
• @donyunardi should we rewrite few tests so that they use regular base plots, so that we don't skip them?

[m7pr]

Or is rmarkdown here just to satisfy the noSuggest check where rmarkdown was not found and when it's in VignetteBuilder then it's found? If this is the only way to do that, then this is fine

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
TableBlock	💚	$13.81$	$-1.12$	$0$	$0$	$0$	$0$

Results for commit 34c6428

♻️ This comment has been updated with latest results.

[donyunardi]

Or is rmarkdown here just to satisfy the noSuggest check where rmarkdown was not found and when it's in VignetteBuilder then it's found? If this is the only way to do that, then this is fine

Yes, @pawelru did the research here

@donyunardi should we rewrite few tests so that they use regular base plots, so that we don't skip them?

That was my first impression too, but we're only skipping this for workflows like noSuggest. Since we have other workflows with all dependencies installed, these tests are still being executed.

If we want to upgrade these test cases to use regular base plots, I support it, but I'd prefer to handle it outside of this issue since it would require more attention.