1352 functions in data raise warnings
#1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Tests pass locally now. |
|
I see 58 issues in tests on local when I run tests for below dependencies. Those are the same as appear in GitHub Actions devtools::test_file('tests/testthat/test-module_teal.R')> packageVersion('teal.slice')
[1] '0.5.1.9011'
> packageVersion('teal.data')
[1] '0.6.0.9010'
> packageVersion('teal') #teal comes from this fork
[1] '0.15.2.9066' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
One warning is removed by extending the
defunctioncall increate_app_idto thedataargument.The other is removed by applying
defunctionto the contents of data when calculating hashes for the integrity check.Improved recursion condition in function
defunction.