Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraint to ActiveSupport gem to use version lower than 7.1 #751

Closed
wants to merge 5 commits into from
Closed

Add constraint to ActiveSupport gem to use version lower than 7.1 #751

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
643f330
Add constraint to ActiveSupport gem to use version lower than 7.1
ahasunos Oct 11, 2023
a783856
Mocha ~1.1 is incompatible with minitest v5.19 and later
ahasunos Oct 12, 2023
98ef3f1
Add conditions for ruby version < 3.1 to install mocha accordingly
ahasunos Oct 12, 2023
8960236
Windows platform for all versions of ruby are unaffected it seems
ahasunos Oct 12, 2023
39608d8
Revert mocha incompatibility changes
ahasunos Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion train.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ Gem::Specification.new do |spec|
spec.add_dependency "train-winrm", "~> 0.2"

# azure, docker, gcp dependencies
spec.add_dependency "activesupport", ">= 6.0.3.1"
# Note: Currently, 7.1.0 causes issue as: `<class:Array>': undefined method `deprecator' for ActiveSupport:Module (NoMethodError)
# Remove the version constraint when we can upgrade to 7.1.1 post stable release of Activesupport 7.1
# More details on the issue: https://github.com/rails/rails/issues/49495
spec.add_dependency "activesupport", ">= 6.0.3.1", "< 7.1"
spec.add_dependency "inifile", "~> 3.0"
spec.add_dependency "azure_graph_rbac", "~> 0.16"
spec.add_dependency "azure_mgmt_key_vault", "~> 0.17"
Expand Down