Skip to content

Commit

Permalink
chore: comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kirrg001 committed Feb 17, 2025
1 parent b6dfdc9 commit 7fceedb
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions packages/collector/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ const log = require('./logger');
const normalizeCollectorConfig = require('./util/normalizeConfig');
const experimental = require('./experimental');

let logger = log.init();
// NOTE: Default collector logger && config for cases like `preinit`.
const logger = log.init();
/** @type {import('./types/collector').CollectorConfig} */
let config = instanaNodeJsCore.util.normalizeConfig({}, logger);
/** @type {import('./agentConnection')} */
Expand Down Expand Up @@ -93,8 +94,13 @@ function init(_config) {
// @ts-ignore: Property '__INSTANA_INITIALIZED' does not exist on type global
global.__INSTANA_INITIALIZED = true;

/** @type {import('@instana/core/src/core').GenericLogger} */
logger = log.init(_config);
// CASE: reinit logger if custom logger or log level is provided.
if (_config && (_config.logger || _config.level)) {
log.init(_config);
}

// TODO: The idea of having a config per parent module probably makes, sense
// but as far as I can see, the code in the collector config module is a duplicate.
config = normalizeCollectorConfig(_config);
config = instanaNodeJsCore.util.normalizeConfig(config, logger);

Expand Down

0 comments on commit 7fceedb

Please sign in to comment.