Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improved logic for ignoring endpoints #1558

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Feb 13, 2025

Refactored the implementation of ignored endpoints by moving the filtering logic to startSpan. This change makes it easier to extend in the future, simplifies modification, and resolves the issue with accessing the current span for ignored span.

Tasks

  • - Refactor the existing span filter logic within the startSpan function.
  • - Get the ignore endpoints config in cls
  • - Perform the span mapping within the span buffer while adding a span.

Pending

@aryamohanan aryamohanan force-pushed the refactor-ignore-endpoints branch from 602809c to e24e0bf Compare February 13, 2025 09:06
@@ -265,6 +264,7 @@ exports.activate = function activate(extraConfig = {}) {
spanBuffer.activate(extraConfig);
opentracing.activate();
sdk.activate();
cls.activate(extraConfig);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the agent config available at the cls.

@aryamohanan aryamohanan removed the WIP label Feb 19, 2025
@aryamohanan aryamohanan marked this pull request as ready for review February 19, 2025 16:12
@aryamohanan aryamohanan requested a review from a team as a code owner February 19, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant