Refactor fetchJson to handle custom timeout #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! Great ideas. We decided instead of having an additional parameter, we'll increase the cap to 5 minutes to match Chrome. #345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISSUES: #287
Found this, apparently the issue isn't closed nodejs/undici#1373
In the Chromium browser, the default timeout is somewhere around 300 second
whereas in node, it is around 30 sec.
possible solution: update the timeouts to prevent this issue
Important
A similar approach to be taken for the browser, to resolve the issue: #138
Possible solution: Have npm package, which lets the user define their own timeout, or maybe pass args to set the timeout