-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make fetchEmails
async
#704
Conversation
WIP, hence PR title isn't linted please approve for testing workflow to run |
Hi @donno2048 ,
Please feel free to ask us any question! |
Sure, I'll change the title when the PR is ready, as for QA, isn't the workflow already doing it? |
Hi @donno2048 , Before that, we need to ensure the functionality by end to end test through the developers. |
My change doesn't affect the function as a whole, only changes the way it is evaluated, so I won't make any new tests as there's nothing new to test... |
I don't mean you have to add a new test case in the codebase. For example, in this PR, I will do manual test by this recipe to ensure it works as expected.
Because we already have had this recipe, please help us modify the title. Thanks for your contribution! 🙇 |
Are you just asking me to change the title? If you already have a recipe to test this with I don't understand what you want..? |
Please just update the title. We will QA on our own. |
Done |
@donno2048 |
Fixed, sorry, I'm on mobile so it's a little complicated to run tests.... |
@donno2048 Let's follow it to make the commit history clean.
|
I'll make a new PR with a clean history... Lots of force pushes here and stuff |
solves instill-ai/instill-core#1111