Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instructor/patch.py): change default mode from FUNCTIONS to TOOLS #436

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

jxnl
Copy link
Collaborator

@jxnl jxnl commented Feb 14, 2024

Ellipsis 🚀 This PR description was created by Ellipsis for commit 0f57b22.

Summary:

This PR changes the default mode from Mode.FUNCTIONS to Mode.TOOLS in several functions in the instructor/patch.py file.

Key points:

  • Changed default mode from Mode.FUNCTIONS to Mode.TOOLS in several functions in instructor/patch.py.
  • Functions affected: process_response, process_response_async, retry_async, retry_sync, and patch (including its overloads).

Generated with ❤️ by ellipsis.dev

@ellipsis-dev ellipsis-dev bot changed the title ... feat(instructor/patch.py): change default mode from FUNCTIONS to TOOLS Feb 14, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Reviewed entire PR up to commit 0f57b22

Reviewed 86 lines of code across 1 files in 40 second(s).

See details
  • Skipped files: 0 (please contact us to request support for these files)
  • Confidence threshold: 85%
  • Drafted 1 additional comments.
  • Workflow ID: wflow_Jl3TttS1pRZwXehi
View 1 draft comments

These comments were drafted by Ellipsis, but were filtered out of the final review. They're included here so you can see our internal thought process and help you configure your ellipsis.yaml.

Drafted 1 comments under confidence threshold

Filtered comment at instructor/patch.py:177

Confidence changes required: 80%

Commentary: The PR changes the default mode from Mode.FUNCTIONS to Mode.TOOLS in multiple functions. This is a significant change and could potentially break existing functionality if not handled properly. I need to check if there are any dependencies on the default mode in the rest of the codebase.

The default mode has been changed from Mode.FUNCTIONS to Mode.TOOLS. This is a significant change and could potentially break existing functionality if not handled properly. Please ensure that all dependencies on the default mode in the rest of the codebase are updated accordingly.


Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.

Generated with ❤️ by ellipsis.dev

@jxnl jxnl enabled auto-merge (squash) February 16, 2024 15:12
@jxnl jxnl disabled auto-merge February 16, 2024 15:13
@jxnl jxnl merged commit 2143805 into main Feb 16, 2024
12 checks passed
@jxnl jxnl deleted the default-tools branch February 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant