-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: Langsmith blogpost #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Reviewed entire PR up to commit d4b174d
Reviewed 332
lines of code across 3
files in 50 second(s).
See details
- Skipped files: 0
- Confidence threshold:
85%
- Drafted
1
additional comments. - Workflow ID:
wflow_xRRafvHqDCoFfBVp
View 1 draft comments
These comments were drafted by Ellipsis, but were filtered out of the final review. They're included here so you can see our internal thought process and help you configure your ellipsis.yaml
.
Drafted 1 additional comments
Filtered comment at mkdocs.yml:174
Notes: The new blog post and hub example have been added to the mkdocs.yml file correctly. However, the blog post file 'langsmith.md' is not added to the mkdocs.yml file. This needs to be corrected.
The new blog post 'langsmith.md' is not added to the mkdocs.yml file. Please add it under the 'Blog' section. For example:
- Langsmith Blogpost: 'blog/posts/langsmith.md'
Confidence changes required: 100%
Score: 0%
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Incremental review on commit d8cf799
Reviewed 18
lines of code across 1
files in 42 second(s).
See details
- Skipped files: 0
- Confidence threshold:
85%
- Drafted
0
additional comments. - Workflow ID:
wflow_c6Ht71dDKsoSpw2g
Something look wrong? Tag @ellipsis-dev in a comment, or customize the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Incremental review on commit 1396283
Reviewed 338
lines of code across 3
files in 1 minute(s) and 6 second(s).
See details
- Skipped files: 0
- Confidence threshold:
85%
- Drafted
3
additional comments. - Workflow ID:
wflow_a52TWi2s9w7NiEWu
View 3 draft comments
These comments were drafted by Ellipsis, but were filtered out of the final review. They're included here so you can see our internal thought process and help you configure your ellipsis.yaml
.
Drafted 3 comments under confidence threshold
Filtered comment at /docs/blog/posts/langsmith.md:1
Notes: The PR introduces a new blog post and a new hub document. Both documents are about using LangSmith with the OpenAI client. The PR also updates the site navigation to include the new hub document. The code in the blog post and the hub document is identical, which is a good practice to maintain consistency. The code is well-written and follows good practices such as using Enums for defining types of questions and using Pydantic for data validation. The code also uses asyncio for handling multiple requests concurrently, which is a good practice for improving performance. The PR description is clear and provides a good summary of the changes. Overall, the PR looks good and I don't see any major issues.
The blog post is well-written and provides a clear explanation of how to use LangSmith with the OpenAI client. The code is also well-written and follows good practices. Good job!
Confidence changes required: 0%
Filtered comment at /docs/hub/batch_classification_langsmith.md:1
Notes: The hub document is identical to the blog post, which is a good practice to maintain consistency. The document provides a clear explanation of how to use LangSmith with the OpenAI client. The code is also well-written and follows good practices. The PR also updates the site navigation to include this new hub document. Overall, the PR looks good and I don't see any major issues.
The hub document is well-written and provides a clear explanation of how to use LangSmith with the OpenAI client. The code is also well-written and follows good practices. Good job!
Confidence changes required: 0%
Filtered comment at /mkdocs.yml:176
Notes: The PR updates the site navigation to include the new hub document. This is a good practice to ensure that the new document is easily accessible to users. The update is correctly done and the new document is placed in the appropriate section of the navigation. Overall, the PR looks good and I don't see any major issues.
The site navigation is correctly updated to include the new hub document. Good job!
Confidence changes required: 0%
Something look wrong? Tag @ellipsis-dev in a comment, or customize the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
Summary:
This PR introduces a new blog post and hub document about using LangSmith with the OpenAI client, and updates the site navigation to include the new hub document.
Key points:
/docs/blog/posts/langsmith.md
/docs/hub/batch_classification_langsmith.md
mkdocs.yml
to include the new hub document in the navigationGenerated with ❤️ by ellipsis.dev