-
-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for gemini models #684
Conversation
Sweep: PR ReviewSweep is currently reviewing your pr... |
can you add a note in the patching notes |
@ellipsis-dev can you try and update the documentation on patch.md docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you jsut add docs to patch.md and the main readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 25c28bb in 3 minutes and 17 seconds
More details
- Looked at
455
lines of code in13
files - Skipped
1
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. instructor/client_gemini.py:9
- Draft comment:
The current implementation lacks support for asynchronous operations, which might be necessary for non-blocking I/O environments. Consider adding async support to align with modern Python practices and to ensure compatibility with async frameworks. - Reason this comment was not posted:
Confidence changes required:66%
The PR description mentions that async, partials/streaming, and tool use are missing. The code provided in the PR does not include any async handling, which is consistent with the description. However, it's important to note that the absence of async support might limit the usability of the gemini integration in environments that require non-blocking operations.
2. pyproject.toml:32
- Draft comment:
Please ensure that the new documentation files (docs/concepts/patching.md
anddocs/index.md
) are added tomkdocs.yml
to make them accessible through the MkDocs site. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 85%.
Workflow ID: wflow_yjUW9cC51ol7iTUd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Out of curiosity - Is there a reason this isn't using the official function calling API? https://cloud.google.com/vertex-ai/generative-ai/docs/multimodal/function-calling |
I have function calling on a branch but the responses are inconsistent and the response payload structure varies with every call. Not reliable enough to recommend at this time. |
|
Yes this is good to go! |
Can this do multi modal ? |
Preliminary support for gemini.
What's currently missing:
Summary:
This PR introduces basic support for Gemini models in the Instructor library, including a new client, updated documentation, and test cases.
Key points:
Generated with ❤️ by ellipsis.dev