Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use short_name instead of name for student-student interactions #3053

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Q-Bea
Copy link

@Q-Bea Q-Bea commented Jan 9, 2025

Changes user.name to user.short_name (or user.shortName) on the PeopleList and PeopleDetails pages when a student is viewing the details of another student.

Rational:

  • This mimics the behaviour of the canvas web client (at least in my experience)

  • "Short name" can also be used a "preferred name" by individuals of various demographics. It is not necessarily safe to assume that ones given name (.name) corresponds with how they wish to be referred as (.short_name).

  • Teachers will still see the name as before, but it may also be worth adding the ability for them to see both a student's preferred and given names.

Note:

  • This is my first time interacting with this codebase and there are probably other changes to be made in order to stay consistent. I don't know where to look, though, and I don't have the ability to test the app on my devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant