Accessibility - Teacher - Calendar - Font size on Edit Event screen #3061
Conversation
affects: Student, Teacher release note: None test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.
ndrsszsz
requested review from
vargaat,
szabinst,
rh12 and
suhaibabsi-inst
as code owners
Teacher Build QR Code: |
Student Build QR Code: |
Affected Apps: Student, Teacher❌ XCTest failed: CoreTests/WKHTTPCookieStoreExtensionsTests/testDeleteAllCookies |
|
|
||
| if date != nil { | ||
| datePicker | ||
| if dynamicTypeSize > .accessibility3 { |
There was a problem hiding this comment.
This limit seems arbitrary to me, but not sure whether is there a proper way to check when would we extend the screen size.
What happens when we have the clear button?
Not sure this works here, but may worth to look into ViewThatFits.
If that fails, what do you think about another way, to add a geometry: GeometryProxy to DatePickerCell and add .frame(maxWidth: geometry.size.width) in there, in place of the .lineLimit(0).
It's less pretty but maybe less hacky as well. The label may disappear in certain conditions, so this is also not a perfect solution.
We could discuss it briefly with the others on Monday.
Please update the other screens which uses this cell as well (EditCalendarToDoScreen, EditCustomFrequencyScreen)
There was a problem hiding this comment.
We should definitely check ViewThatFits since that's the way Apple proposes for such use cases.
There was a problem hiding this comment.
There's a sweet spot where the date is cropped in a single line. If I increase the font size it will break into two lines but the date text will still start out of the screen. I guess the date text itself widens the stack out of screen and the label just aligns to it.
ndrsszsz
deleted the
bugfix/MBL-18306-a11y-teacher-calendar-event-font-size
branch
affects: Student, Teacher
release note: None
test plan: No text should get cut off on EditCalendarEventScreen when font size is increased to the maximum.
I'm not quite pleased with the solution so any suggestion is appreciated.
Before:
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-14.at.12.42.53.mp4
After:
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2025-01-14.at.12.39.56.mp4
Checklist