Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shared-types,ui-buttons): add theme variables for default and hover states for buttons #1840

Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat(shared-types,ui-buttons): add theme variables for default and hover states for buttons #1840

merged 1 commit into from
Jan 10, 2025

Conversation

HerrTopi
Copy link
Contributor

@HerrTopi HerrTopi commented Jan 7, 2025

Closes: INSTUI-4421

@HerrTopi HerrTopi requested review from matyasf and joyenjoyer January 7, 2025 17:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

PR Preview Action v1.5.0
Preview removed because the pull request was closed.
2025-01-10 03:39 UTC

@matyasf
Copy link
Collaborator

matyasf commented Jan 8, 2025

Can you expand the example here? https://instructure.design/pr-preview/pr-1840/#Button/#Styling%20buttons

matyasf
matyasf approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

joyenjoyer
joyenjoyer approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@matyasf matyasf requested a review from a team January 9, 2025 08:28
igera93
igera93 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@igera93 igera93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, I checked and it's exactly what I needed ;)

@HerrTopi HerrTopi merged commit 43fde61 into master Jan 10, 2025
11 checks passed
@HerrTopi HerrTopi deleted the iconbuttonshadow branch January 10, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igera93 igera93 igera93 approved these changes

@joyenjoyer joyenjoyer joyenjoyer approved these changes

@matyasf matyasf matyasf approved these changes

Assignees

@HerrTopi HerrTopi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HerrTopi @matyasf @joyenjoyer @igera93