-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added !NEW! SimpleColor action block #928
base: stable
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 849ddc5): https://grid-editor-web--pr928-feat-colorpicker-pymhtjs9.web.app (expires Fri, 21 Feb 2025 14:31:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f |
Can we move the ColorPicker components to the uikit library? |
Test Failed:Issues:
env: MacOS Screen.Recording.2025-02-13.at.11.30.16.mov |
We'll issue an updated design for the colorbar as it looks too much like a slider and causes the user expectation that it's clickable and slide-able. That's on the design, we'll fix it. Aside from this the feature looks as specified. Nice! However I can only echo the sentiments of @Greg-Orca above:
Also the sequence of events when adding new colors is wrong. Now what it does is: What it should be doing instead: |
|
The expected behaviour and design proposal is described in the ticket that this PR closes. See below.
Closes #912