Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed runtime error on monaco open with grid layout shift #972

Open
wants to merge 3 commits into
base: stable
Choose a base branch
from

Conversation

elsoazemelet
Copy link
Contributor

Closes #915

Copy link
Contributor

github-actions bot commented Feb 12, 2025

Visit the preview URL for this PR (updated for commit 9aa1b42):

https://grid-editor-web--pr972-bug-layoutshift-0o5iyviv.web.app

(expires Mon, 24 Feb 2025 15:42:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@Greg-Orca
Copy link
Contributor

Greg-Orca commented Feb 13, 2025

Test failed:

Issue:

  • Editor freeze when when module is not in default position and open the codeblock

@elsoazemelet
Copy link
Contributor Author

Test failed:

Issue:

  • Editor freeze when when module is not in default position and open the codeblock

Can not repro the reported issue.

Editor.-.Google.Chrome.2025-02-14.15-45-12.mp4

@Greg-Orca
Copy link
Contributor

Sorry, the issue was not described properly. If you write/modify the codeblock, then Grid Editor freeze

@elsoazemelet
Copy link
Contributor Author

elsoazemelet commented Feb 17, 2025

  • Remove window event listening from onMount/onDestroy in MiddlePanelContainer
  • Rethink lightweight subscription handling

@Greg-Orca
Copy link
Contributor

Test Passed

tested zoom in/out and move with:

  • codeblock
  • comment block
  • element name
  • local block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Editor breaks if code block is opened when modul is not in default position
2 participants