-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUKU self:draw_pixel implemented #147
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.00 (8.93 -> 8.93)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.00 (8.93 -> 8.93)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.06 (7.25 -> 7.31)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.06 (7.25 -> 7.31)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.06 (7.25 -> 7.31)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.02 (7.25 -> 7.27)
- Improving Code Health: 1 findings(s) ✅
@@ -51,25 +51,30 @@ int l_grid_gui_draw_pixel(lua_State* L) { | |||
|
|||
// grid_platform_printf("TEST GUI: l_grid_gui_draw_pixel\r\n"); | |||
|
|||
int x = luaL_checknumber(L, 1); | |||
int y = luaL_checknumber(L, 2); | |||
int screen_index = luaL_checknumber(L, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Getting better: Code Duplication
reduced similar code in: l_grid_gui_draw_pixel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.02 (7.25 -> 7.27)
- Improving Code Health: 1 findings(s) ✅
Limitation
Encoder specific change
Global function change
LCD element specific changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: +0.02 (7.25 -> 7.27)
- Improving Code Health: 1 findings(s) ✅
GUI changes work as expected. Unable to upload FW to modules with encoders, not possible to test. When attempting to upload, after FW boots purple flashing is observed. |
No description provided.