migtd: simplify the GHCI implementation #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0314/simplify_ghci_impl
branch
from
239f73e
to
9b391a3
Compare
The old implementation of migtd GHCI uses a state machine to switch between waiting, migration and status reporting which is an overdesign. The patch simplifies the implementation by: - Removing the state machine of MigrationSession and exposing several individual APIs of GHCI. - Abstract the service vmcall operations into VmcallService to reduce the duplicate code. The changes will make the implementation simpler and easier to read. More unit test can be added for individual APIs. Signed-off-by: Jiaqi Gao <[email protected]>
It can only be built for baremetal target and run in baremetal TDX environment. Move this to bin to avoid lots of conditional compilation in `migration` module under lib. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0314/simplify_ghci_impl
branch
from
9b391a3
to
5a04c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
individual APIs of GHCI.
the duplicate code.
exchange_mskfunction tobin