migtd: record hash of event in event log #309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events of migtd, such as policy events, are particularly large in size. Since the event log is written into the RATLS certificate, this results in a significant increase in the size of the RATLS certificate. Using the hash of the event instead of the raw data can save space in the event log and reduce the size of the certificate. Signed-off-by: Jiaqi Gao <[email protected]>
jyao1
reviewed
Oct 23, 2024
| let digest = calculate_digest(tagged_event_data)?; | ||
| let event = TaggedEvent::new(tagged_event_id, &digest); |
There was a problem hiding this comment.
The digest is already recorded.
I think we only need to add descriptor.
Please refer to https://trustedcomputinggroup.org/resource/pc-client-specific-platform-firmware-profile-specification/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events of migtd, such as policy events, are particularly large in size. Since the event log is written into the RATLS certificate, this results in a significant increase in the size of the RATLS certificate. Using the hash of the event instead of the raw data can save space in the event log and reduce the size of the certificate.