feat: tempclean Ruby #3943
Merged
feat: tempclean Ruby #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes
Changes-2
Changes
Changes
Changes
Changes
Changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
+ Coverage 75.41% 75.84% +0.42%
==========================================
Files 808 820 +12
Lines 11983 12405 +422
Branches 1598 1680 +82
==========================================
+ Hits 9037 9408 +371
- Misses 2593 2644 +51
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
terriko
requested changes
Mar 20, 2024
Co-authored-by: Terri Oda <[email protected]>
|
I think its ready to merge now @terriko @anthonyharrison. |
Signed-off-by: Joydeep Tripathy <[email protected]>
Signed-off-by: Joydeep Tripathy <[email protected]>
terriko
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Looks good. I'm still wondering if we should maybe switch to the with syntax for these, but since there's no functional difference I think I'm going to err on the side of getting these merged and debating a refactor at another time.
Thanks for your patience, I know these have been sitting a while!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tempclean script added to RubyFuzzer