-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update argument list #4443
Conversation
Signed-off-by: Aryan Bakliwal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thanks for the Pull Request, I have minor nitpick.
|
||
CVE Data Download: | ||
Arguments related to data sources and Cache Configuration | ||
|
||
-n {api,api2,json-nvd,json-mirror}, --nvd {api,api2,json-nvd,json-mirror} | ||
-n {api,api2,json,json-mirror,json-nvd}, --nvd {api,api2,json,json-mirror,json-nvd} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terriko I was wondering should we remove "api" its been time since we deprecated nvd api 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm intending to keep it until we declare 4.0. Right now it's barely any work to just leave it there so I wasn't going to worry about it until we start looking at stuff like re-architecting for no-scan mode.
Signed-off-by: Aryan Bakliwal <[email protected]>
I have addressed the changes pointed out by @mastersans and also some other minor inconsistencies. Should I change these in the cli file as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
I'm going to merge this but please go ahead and make changes to cli.py as needed to make it match in a separate PR.
fixes: #4393
Updated the arguments list in both MANUAL.md and README.md