-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checker): Add imagemagick #4739
base: main
Are you sure you want to change the base?
Conversation
fd2d147
to
718d2d7
Compare
@terriko I addressed the merge conflict and the linting failure, would you mind re-approving the workflow? |
@terriko Looks like the "Testing / Tests that may fail due to network or HTML (pull_request)" test failed and the "Testing / Long tests on Python 3.10 (synchronous) (pull_request)" test was cancelled (?). Could you re-run those jobs? |
I'm going to update this branch so you should get the long tests on 3.13, which should work better. I'm not too worried about the synch tests failing in this case since the scanner tests passed, but might as well be sure. |
08df33d
to
51da9fa
Compare
Thanks @terriko . Looks like you'll still need to approve the workflow, though. |
Done! (Sorry about forgetting to re-approve it. They changed the interface so I have to do that now but it still doesn't show for me that it's needed unless I refresh the page for some reason. ugh.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the merge conflict, but of course now all the tests are going to run again. I know branch requirements are considered best practice but sometimes they're such a waste of time!
No description provided.