Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(output_engine): add regression tests for unset data #4788

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

JigyasuRajput
Copy link
Contributor

Description:

Fixes #4441 this PR introduces regression tests to verify OutputEngine behavior when certain optional fields are unset. Specifically, it addresses cases like sbom_serial_number to prevent future issues similar to #4438.

Changes Made:

  • Added a test case test_output_with_unset_fields in test_output_engine.py
  • Ensures OutputEngine initializes correctly when sbom_serial_number is missing
  • Uses subTest to allow future extension for more unset fields
  • Verifies that output_cves does not raise exceptions when handling missing values

Testing:

  • Verified output consistency when sbom_serial_number is unset

@terriko
Copy link
Contributor

terriko commented Feb 10, 2025

This looks ok. I'm going to let the tests run and come back for a more careful review once they're passing. Thank you!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge time! Thank you again, I'm very glad to have a regression test here.

@terriko terriko merged commit b627947 into intel:main Feb 13, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: regression tests for unset data
2 participants