ci(pre-commit): update isort stages to fix deprecation warning #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
reviewed
Feb 10, 2025
@terriko Thanks for catching that! The correct stage names are |
|
ok, glad it's correct in the code. I've set the workflow to run again so that the required tests pass; I'll be back to merge it after they're done. |
terriko
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #4537 this updates the
.pre-commit-config.yamlto resolve the isort deprecation warning related to outdated stage names (commit,merge-commit,push). The fix involves:pre-commit autoupdateto updateisort.pre-commit,pre-merge-commit).Changes:
.pre-commit-config.yamlwith the correctisortstages.Testing:
pre-commit run --all-filesto verify there are no warnings/errors.