Remove matmul primitive caching in ideep #339
Draft
+4
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes aarch64 specific code branches for caching oneDNN matmul primitive in ideep. Instead, we rely on primitive caching in oneDNN. Since oneDNN v3.6 matmul primitive with ACL backend leverages the experimental stateless API in ACL and thus can be cached more efficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes aarch64 specific code branches for caching oneDNN matmul primitive in ideep.
Instead, we rely on primitive caching in oneDNN. Since oneDNN v3.6 matmul primitive with ACL
backend leverages the experimental stateless API in ACL and thus can be cached more efficiently.
The work to make ACL lowp matmul primitive is still in progress. Please hold off merging this PR
until that work is done.