Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 0.32.0 release #1964

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Prepare for 0.32.0 release #1964

merged 4 commits into from
Jan 29, 2025

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Jan 22, 2025

No description provided.

hj-johannes-lee
hj-johannes-lee reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that README.md remains the same as v0.31. I don't know if you did it on purpose for some reason, but just in case I comment.! :)

@mythi
Copy link
Contributor

mythi commented Jan 23, 2025

Seems that README.md remains the same as v0.31. I don't know if you did it on purpose for some reason, but just in case I comment.! :)

@hj-johannes-lee good catch. Yes we have updated the README in release branches too so it's good to get that added here too

@tkatila
Copy link
Contributor Author

tkatila commented Jan 23, 2025

thanks @hj-johannes-lee 👍. Those changes are now added.

eero-t
eero-t requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to: https://dgpu-docs.intel.com/devices/hardware-table.html

NFD rules are missing for following ARC / Alchemist GPU IDs with Xe-HPG architecture:

  • 56A2
  • 56BA
  • 56BC
  • 56BD
  • 56BB

There are also couple of newer Xe-LPG & Xe2 architecture iGPUs with ARC branding:

  • 7D55 (MeteorLake)
  • 64A0 (LunarLake)

But I guess iGPUs can be skipped from that list.

However, I think there could be new platform rule for the recent Battlemage series dGPU PCI IDs:

  • E20B
  • E20C

@tkatila
Copy link
Contributor Author

tkatila commented Jan 28, 2025

According to: https://dgpu-docs.intel.com/devices/hardware-table.html

NFD rules are missing for following ARC / Alchemist GPU IDs with Xe-HPG architecture:

I'm not disagreeing that they are missing, but are they preventing the use of GPU plugin with those devices? afaik, the answer is no. It's just the additional label related to arc and/or battlemage devices.

@eero-t
Copy link
Contributor

eero-t commented Jan 28, 2025 •
edited
Loading

I'm not insisting BMG one, but as long as Arc label is used, it should include correct list of devices. If that label is deprecated, then it would be OK to not keep it up to date.

eero-t
eero-t approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@mythi mythi merged commit 541e69a into intel:release-0.32 Jan 29, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hj-johannes-lee hj-johannes-lee hj-johannes-lee left review comments

@eero-t eero-t eero-t approved these changes

@mythi mythi mythi approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@ozhuraki ozhuraki Awaiting requested review from ozhuraki ozhuraki is a code owner

@kad kad Awaiting requested review from kad kad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tkatila @mythi @eero-t @hj-johannes-lee