Meson warning fixups #549
Open
Meson warning fixups #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
force-pushed
the
meson-warning-fixups
branch
2 times, most recently
from
cb5ffa1
to
9386b67
Compare
|
Setting the |
This function has never taken a number, only a boolean. Due to leaky python implementation details, it cast literally anything to bool regardless, including somewhat common accidental usage of numbers. This now prints an unavoidable deprecation notice stating that it may be removed at any time. Fix this to use what was always intended -- .set(), as used a few lines down for another number. Signed-off-by: Eli Schwartz <[email protected]>
eli-schwartz
force-pushed
the
meson-warning-fixups
branch
from
9386b67
to
dad1f2f
Compare
|
libva already uses Perhaps it would worth to bump to the same version or, at least to 0.47 |
Recent versions of Meson warn you that the default is to not check the return code, which is a bad default and may eventually change. To suppress this warning, an explicit `check: ` value must be set. Considering the code in play here: - check if git exists - if so, always assume this is running from a git checkout - embed either '()' or '(git describe version)' it seems likely the intention is indeed to have it be `check: false`, but there's some missing error checking here to ensure it. Check the returncode. If git fails, it is surely because there is no git repository and the build is being run from a tarball. In that case, behave as though git wasn't found in the first place, and use the fallback value. Suppressing the warning means bumping the minimum version of Meson. This can be safely done since both the previous and new minimums are quite old, and libva already depends on a much newer version. Signed-off-by: Eli Schwartz <[email protected]>
eli-schwartz
force-pushed
the
meson-warning-fixups
branch
from
dad1f2f
to
46898db
Compare
|
Good point, done. |
|
(Sorry to bother) When will this be merged? |
|
I would be happy to receive clarification on that as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.