Merge OpenAI Triton commit 716a521
#3361
Draft
+116
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoisting layout conversions into ifs relies on the assumption that the if infrequently executes, but this assumption only makes sense in a loop. A single top-level if in a kernel either executes or it doesn't, and if the hoist is incorrect, it can lead to a slowdown.
Since we load data in the column major format with `ldmatrix.trans`, pre-blackwell hardware seems difficult to support the transpose case.
Simplify pipelining by removing outer loop pipelining transformation. Performance benefits of it are smaller than pipelining fused persistent loops, while making the pipeliner harder to maintain and refactor.
The folder for TransOp was a bit too aggresive. Sometimes it would change the representation of a layout for an equivalent one, and that's not allowed in the current state of things. We move the optimisation we had to a different canonicalizer.
If we expect a warning, we need to use a fresh cache dir; otherwise, no warning will be thrown when the cache is hit. Also take out interpreter related code from this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the Triton base from 1e0e51c to 716a521 (Feb 4).
Pass rate: 98.19%
Please do not squash and merge this PR.