[Media Common][VP] fix compressed surface width not align with 32 and seg fault #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan-debug
force-pushed
the
32alignissue
branch
2 times, most recently
from
1181d06
to
bacfc22
Compare
Dylan-debug
force-pushed
the
32alignissue
branch
2 times, most recently
from
47e05bc
to
599340a
Compare
| @@ -5192,7 +5192,7 @@ VAStatus SwizzleSurface(PDDI_MEDIA_CONTEXT mediaCtx, PGMM_RESOURCE_INFO pGmmResI | |||
|
|
|||
| memset(&gmmResCopyBlt, 0x0, sizeof(GMM_RES_COPY_BLT)); | |||
| uiPicHeight = pGmmResInfo->GetBaseHeight(); | |||
| uiSize = pGmmResInfo->GetSizeSurface(); | |||
| uiSize = pGmmResInfo->GetSizeMainSurface(); | |||
There was a problem hiding this comment.
what's "main" , compare with aux plan of compressed surface ?
There was a problem hiding this comment.
MainSize is not include auxplan. We need pass the right size correspondent right Plane number.
There was a problem hiding this comment.
does pGmmResInfo->CpuBlt support MMC?
if not, only support non-compressed surface
GetSizeSurface should be same as GetSizeMainSurface?
MicroYY
reviewed
Jul 28, 2023
| @@ -663,7 +663,37 @@ MOS_STATUS MediaVeboxDecompState::GetResourceInfo(PMOS_SURFACE surface) | |||
| &resDetails)); | |||
|
|
|||
| surface->Format = resDetails.Format; | |||
| #ifdef LINUX | |||
There was a problem hiding this comment.
@XinfengZhang Can we add such macro?
There was a problem hiding this comment.
yes, we can. We can add such macro in mos layer. you can find such macro on this cpp file.
Dylan-debug
force-pushed
the
32alignissue
branch
from
599340a
to
69c15c7
Compare
Guangyao-Bai
approved these changes
Jul 31, 2023
Dylan-debug
force-pushed
the
32alignissue
branch
from
69c15c7
to
5fba540
Compare
hye5
approved these changes
Jul 31, 2023
Dylan-debug
changed the title
Dylan-debug
force-pushed
the
32alignissue
branch
from
5fba540
to
fdc0925
Compare
XinfengZhang
approved these changes
Aug 1, 2023
Dylan-debug
force-pushed
the
32alignissue
branch
from
fdc0925
to
ca1abd0
Compare
caused by wrong plane number
Dylan-debug
force-pushed
the
32alignissue
branch
2 times, most recently
from
293f324
to
c887e36
Compare
|
@Dylan-debug could you rebase the patch for merging? |
|
merged in 5621e3f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix compressed surface width not align with 32 and seg fault caused by wrong plane number passed to gmm
Signed-off-by: caij [email protected]