[Media Common] Add DRM format mappings for JPEG decoder output #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipl
force-pushed
the
imc3-drm-format
branch
2 times, most recently
from
798dc4d
to
633a91e
Compare
philipl
changed the title
The output formats from the JPEG decoder are currently not included in the DRM format mapping functions. This means that any attempt to call vaExportSurface on JPEG images will fail. However, there is no functional gap beyond the missing mappings, so if we add them in, exporting will then work correctly. The four formats in question are IMC3, 422H, 422V, and 444P. * 422H and 444P have trivial 1:1 mappings. * IMC3 can be treated the same as I420, because the only difference is the chroma pitch, and that's explicitly set in the descriptor * 422V (aka 440P) has the same memory layout as 422H - it's just a difference in how the consumer handle the chroma I also added the missing XYUV composite object mapping - it was already present for separate planes. Tested with ffmpeg+mpv.
philipl
force-pushed
the
imc3-drm-format
branch
from
633a91e
to
f450abf
Compare
Jexu
approved these changes
Aug 11, 2023
|
Hi @philipl , thanks for your fix that helps it work in media lagecy code path. But intel xe plaforms will switch to the APO code path under media_softlet, so could you also help port this fix there in https://github.com/intel/media-driver/blob/master/media_softlet/linux/common/ddi/media_libva_interface_next.cpp? |
|
See #1718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output formats from the JPEG decoder are currently not included
in the DRM format mapping functions. This means that any attempt to
call vaExportSurface on JPEG images will fail.
However, there is no functional gap beyond the missing mappings, so if
we add them in, exporting will then work correctly.
The four formats in question are IMC3, 422H, 422V, and 444P.
the chroma pitch, and that's explicitly set in the descriptor
difference in how the consumer handle the chroma
I also added the missing XYUV composite object mapping - it was already
present for separate planes.
Tested with ffmpeg+mpv.