Skip to content
This repository has been archived by the owner on Mar 14, 2020. It is now read-only.

[UI] Refined the navigator with CSS. #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[UI] Refined the navigator with CSS. #285

wants to merge 1 commit into from

Conversation

xuqingkuang
Copy link
Contributor

No description provided.

@xuqingkuang
Copy link
Contributor Author

@zhizhangchen After Chrome upgraded, the width computing seems correct.

The css and home icon is updated, it could be in review now.

@zhizhangchen
Copy link
Contributor

In Linux, the font seems a little grey and thin.

@xuqingkuang
Copy link
Contributor Author

@zhizhangchen The font changed to OpenSans-SB, looks more bold now.

@sbryan
Copy link
Contributor

sbryan commented Sep 14, 2012

Why are we changing these so drastically, especially by adding more hard coded sizes (which is causing zoom issues)?

Was there a bug for this?

Also, now the tabs section in the navbar does not align with the initial width of the left panel (contains page picker, outline view and property view), so the initial visual presentation looks odd.

@sbryan
Copy link
Contributor

sbryan commented Sep 14, 2012

OK, so I see now that we never replaced the view tab button images with real CSS. Unfortunately, I'm not liking the way it's being done with the hard coded sizes and having to add the text content of the href in the code.

By adding the following to builder.css, you can remove the code changes to main.js:

.layoutViewButton:after { content: "layout"; }
.codeViewButton:after { content: "code"; }
.liveViewButton:after { content: "preview"; }

There are other places where we could be doing things better. I will see if I can make code suggestions.

@xuqingkuang
Copy link
Contributor Author

@sbryan How about place the text contents in main.js ? it will make RIB internationalize in future more easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants