This repository has been archived by the owner on Mar 14, 2020. It is now read-only.
[Layout View] Improve the sorting algorithm to solve jittering problem #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change, I can no longer move a button to the first position in a horizontal (inline) layout container, such as a footer. Test case:
I am unable to make this work at all anymore. Same is true for horizontal button groups Also, it seems that list items in a list can no longer be sorted either... not sure if it is related, but I can see the behavior difference between the 01.org/rib/online version and master Please go back and retest more thoroughly and fix or note regressions. |
Direction is now determined only by the border the mouse is nearer
|
I fixed all the bugs you mentioned. Please review. Thanks! |
jQuery UI's floating caculation overlooks the fact that items may come from other connected containers which may not be horizontal while this container is horizontal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direction is now determined only by the border the mouse is nearer