This repository has been archived by the owner on Mar 14, 2020. It is now read-only.
[Widget View] Implemented recent widgets feature. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is updated, please review. Thx a lot! @zhizhangchen |
| @@ -110,7 +112,7 @@ | |||
|
|
|||
| // First unbind our ADMDesign modelUpdated handler, if any... | |||
| if (d && o.modelUpdated) { | |||
| d.designRoot.unbind("modelUpdated", o.modelUpdated, this); | |||
| d.unbind("modelUpdated", o.modelUpdated, this); | |||
There was a problem hiding this comment.
Why are you removing the "designRoot" when unbinding modelUpdated?
|
@zhizhangchen The code is updated by your comments, please review. |
| @@ -109,7 +111,7 @@ | |||
| d = this.designRoot; | |||
|
|
|||
| // First unbind our ADMDesign modelUpdated handler, if any... | |||
| if (d && o.modelUpdated) { | |||
| if (d && d.designRoot && o.modelUpdated) { | |||
There was a problem hiding this comment.
d.designRoot should be this.designRoot
There was a problem hiding this comment.
Please see line 114 - d = this.designRoot.
|
@zhizhangchen The code updated by your comments, please review. |
|
The code updated by your comments, please review. @zhizhangchen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.