Skip to content

Commit

Permalink
persist_ckpt option path args
Browse files Browse the repository at this point in the history
  • Loading branch information
liyanzhe.lyz committed Jan 22, 2025
1 parent 262e63b commit 1a15252
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dlrover/python/training_event/predefined/trainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def init(self, **kwargs) -> TrainInitSpan:
"""
return self.custom_duration(TrainInitSpan, TrainerEventName.TRAIN_INIT.value, kwargs)

Check warning on line 119 in dlrover/python/training_event/predefined/trainer.py

View check run for this annotation

Codecov / codecov/patch

dlrover/python/training_event/predefined/trainer.py#L119

Added line #L119 was not covered by tests

def persist_ckpt(self, global_step: int, path: str, size: Optional[int] = None, **kwargs):
def persist_ckpt(self, global_step: int, path: str = "", size: Optional[int] = None, **kwargs):
"""
persist_ckpt event used in async checkpoint saving. stands for the training
process is persisting
Expand Down

0 comments on commit 1a15252

Please sign in to comment.