check if pod is already running before relaunch #1407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majieyue
requested review from
workingloong,
samplise and
BalaBalaYi
as code owners
|
|
||
| # Even _should_relaunch return True by state-machine check, | ||
| # we need another round of check | ||
| if should_relaunch: |
There was a problem hiding this comment.
Move these codes into the method _should_relaunch and add UT.
BalaBalaYi
requested changes
Dec 27, 2024
| selector = k8s_util.gen_k8s_label_selector_from_dict( | ||
| self._get_pod_unique_labels(cur_node) | ||
| ) | ||
| logger.info( |
There was a problem hiding this comment.
This part has actually already been implemented (when generating the event before relaunch), so the issue probably isn't here.
There was a problem hiding this comment.
event type is MODIFIED and node status is RUNNING from log. so the condition in _process_event is not matched.
There was a problem hiding this comment.
modified event with deletion timestamp will transfer to deleted event:
dlrover/dlrover/python/master/watcher/k8s_watcher.py
Lines 229 to 235 in 5d070f4
|
The issue is resolved by: #1408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
check pod is duplicated before relaunch another one
Why are the changes needed?
some k8s plugin can recover pod from starting failure. when a pod is deleted or modified from a pending/running state, the pod with the same rank and id may be already running successfully. so we should not relaunch another same rank pod
Does this PR introduce any user-facing change?
No
How was this patch tested?
BVT UT