if node failed and exited, need relaunch on heartbeat timeout #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….g. upload corefile, we need to relaunch at once without waiting
majieyue
requested review from
workingloong,
samplise and
BalaBalaYi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
- Coverage 81.15% 81.14% -0.01%
==========================================
Files 237 237
Lines 23131 23144 +13
==========================================
+ Hits 18771 18780 +9
- Misses 4360 4364 +4 ☔ View full report in Codecov by Sentry. |
liyzcj
pushed a commit
that referenced
this pull request
Jan 22, 2025
….g. upload corefile, we need to relaunch at once without waiting (#1420) Co-authored-by: Ma Jie Yue <[email protected]> Co-authored-by: Tianyi Chen <[email protected]> (cherry picked from commit e3a2f9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
change dead node skip to only succeeded exit node
Why are the changes needed?
if node failed and exited, but stuck into some post-mortem action such as coredump upload, we won't wait for it finishing, but relaunch as soon as the heartbeat timeout
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT