Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to move go files to the first directory. #1424

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/brain-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ runs:
args:
- "/bin/bash"
- "-c"
- "cd dlrover/go/brain/pkg && go test ./..."
- "cd go/brain/pkg && go test ./..."
2 changes: 1 addition & 1 deletion .github/actions/go-master-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ runs:
wget -q https://go.dev/dl/go1.23.4.linux-amd64.tar.gz && \
tar -C /usr/local -xzf go1.23.4.linux-amd64.tar.gz && \
go install github.com/onsi/ginkgo/v2/[email protected] &&
cd dlrover/go/master && ginkgo -v ./..."
cd go/master && ginkgo -v ./..."
2 changes: 1 addition & 1 deletion .github/actions/operator-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ runs:
args:
- "/bin/bash"
- "-c"
- "cd dlrover/go/operator && go test ./..."
- "cd go/operator && go test ./..."
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ share/python-wheels/
*.egg
MANIFEST
*.ckpt
dlrover/go/operator/bin/
go/operator/bin/

# PyInstaller
# Usually these files are written by a python script from a template
Expand Down
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ repos:
entry: bash ./scripts/codestyle/clang_format.hook -i
language: system
files: \.(c|cc|cxx|cpp|cu|h|hpp|hxx|proto)$
exclude: dlrover/go/brain/vendor
exclude: go/brain/vendor
- repo: local
hooks:
- id: cpplint-cpp-source
Expand All @@ -38,20 +38,20 @@ repos:
entry: bash ./scripts/codestyle/cpplint_precommit.hook
language: system
files: \.(c|cc|cxx|cpp|cu|h|hpp|hxx)$
exclude: dlrover/go/brain/vendor
exclude: go/brain/vendor
- repo: https://github.com/dnephin/pre-commit-golang.git
rev: v0.3.3
hooks:
- id: go-fmt
exclude: dlrover/go/brain/vendor
exclude: go/brain/vendor
- id: go-lint
exclude: dlrover/go/brain/vendor
exclude: go/brain/vendor
- id: no-go-testing
- repo: https://github.com/gruntwork-io/pre-commit
rev: v0.1.8
hooks:
- id: shellcheck
exclude: dlrover/go/brain/vendor
exclude: go/brain/vendor
files: \.(sh)$
- repo: local
hooks:
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion dlrover/go/brain/go.mod → go/brain/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require (
github.com/go-sql-driver/mysql v1.6.0
github.com/golang/glog v1.0.0
github.com/golang/protobuf v1.5.2
github.com/intelligent-machine-learning/easydl/dlrover/go/operator v0.0.0-20221220215741-7f4cde713fd9
github.com/intelligent-machine-learning/dlrover/go/operator v0.0.0-20221220215741-7f4cde713fd9
github.com/stretchr/testify v1.8.1
golang.org/x/net v0.4.0
google.golang.org/grpc v1.51.0
Expand Down
4 changes: 2 additions & 2 deletions dlrover/go/brain/go.sum → go/brain/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ github.com/imdario/mergo v0.3.12 h1:b6R2BslTbIEToALKP7LxUvijTsNI9TAe80pLWN2g/HU=
github.com/imdario/mergo v0.3.12/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA=
github.com/inconshreveable/mousetrap v1.0.0/go.mod h1:PxqpIevigyE2G7u3NXJIT2ANytuPF1OarO4DADm73n8=
github.com/influxdata/influxdb1-client v0.0.0-20191209144304-8bf82d3c094d/go.mod h1:qj24IKcXYK6Iy9ceXlo3Tc+vtHo9lIhSX5JddghvEPo=
github.com/intelligent-machine-learning/easydl/dlrover/go/operator v0.0.0-20221220215741-7f4cde713fd9 h1:K3ClltLxvZfrfAZ4HsrluAK/7lag81L/vDrCCk5lUjk=
github.com/intelligent-machine-learning/easydl/dlrover/go/operator v0.0.0-20221220215741-7f4cde713fd9/go.mod h1:N3KDezonC4927+EZuYkeJzhjL4hTwMBPytUFsGPiud8=
github.com/intelligent-machine-learning/dlrover/go/operator v0.0.0-20221220215741-7f4cde713fd9 h1:K3ClltLxvZfrfAZ4HsrluAK/7lag81L/vDrCCk5lUjk=
github.com/intelligent-machine-learning/dlrover/go/operator v0.0.0-20221220215741-7f4cde713fd9/go.mod h1:N3KDezonC4927+EZuYkeJzhjL4hTwMBPytUFsGPiud8=
github.com/jackc/chunkreader v1.0.0/go.mod h1:RT6O25fNZIuasFJRyZ4R/Y2BbhasbmZXF9QQ7T3kePo=
github.com/jackc/chunkreader/v2 v2.0.0/go.mod h1:odVSm741yZoC3dpHEUXIqA9tQRhFrgOHwnPIn9lDKlk=
github.com/jackc/chunkreader/v2 v2.0.1/go.mod h1:odVSm741yZoC3dpHEUXIqA9tQRhFrgOHwnPIn9lDKlk=
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,19 @@
package watchhandler

import (
"time"

log "github.com/golang/glog"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
"github.com/intelligent-machine-learning/easydl/brain/pkg/common"
"github.com/intelligent-machine-learning/easydl/brain/pkg/config"
datastoreapi "github.com/intelligent-machine-learning/easydl/brain/pkg/datastore/api"
"github.com/intelligent-machine-learning/easydl/brain/pkg/datastore/recorder/mysql"
k8scommon "github.com/intelligent-machine-learning/easydl/brain/pkg/platform/k8s/common"
handlerutils "github.com/intelligent-machine-learning/easydl/brain/pkg/platform/k8s/implementation/watchhandler/utils"
watchercommon "github.com/intelligent-machine-learning/easydl/brain/pkg/platform/k8s/watcher/common"
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime"
"time"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,17 @@ package watcher
import (
"context"
"fmt"
"sync"

log "github.com/golang/glog"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
"github.com/intelligent-machine-learning/easydl/brain/pkg/common"
"github.com/intelligent-machine-learning/easydl/brain/pkg/config"
"github.com/intelligent-machine-learning/easydl/brain/pkg/datastore"
handlerimpl "github.com/intelligent-machine-learning/easydl/brain/pkg/platform/k8s/implementation/watchhandler"
watchercommon "github.com/intelligent-machine-learning/easydl/brain/pkg/platform/k8s/watcher/common"
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
"k8s.io/client-go/kubernetes"
k8smanager "sigs.k8s.io/controller-runtime/pkg/manager"
"sync"
)

const (
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions dlrover/go/operator/PROJECT → go/operator/PROJECT
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ domain: iml.github.io
layout:
- go.kubebuilder.io/v3
projectName: operator
repo: github.com/intelligent-machine-learning/easydl/dlrover/go/operator
repo: github.com/intelligent-machine-learning/dlrover/go/operator
resources:
- api:
crdVersion: v1
Expand All @@ -11,6 +11,6 @@ resources:
domain: iml.github.io
group: elastic
kind: ElasticJob
path: github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1
path: github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1
version: v1alpha1
version: "3"
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
package v1alpha1

import (
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
package v1alpha1

import (
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dlrover/go/operator/go.mod → go/operator/go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/intelligent-machine-learning/easydl/dlrover/go/operator
module github.com/intelligent-machine-learning/dlrover/go/operator

go 1.18

Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions dlrover/go/operator/main.go → go/operator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ import (
"sigs.k8s.io/controller-runtime/pkg/healthz"
"sigs.k8s.io/controller-runtime/pkg/log/zap"

elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
"github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/controllers"
_ "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/controllers/training"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
"github.com/intelligent-machine-learning/dlrover/go/operator/pkg/controllers"
_ "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/controllers/training"
//+kubebuilder:scaffold:imports
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
package common

import (
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
apiv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
apiv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ package common

import (
"context"

"github.com/golang/glog"
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
logger "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@
package common

import (
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
"testing"

elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
"github.com/stretchr/testify/assert"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"testing"
)

func newTestJob() *elasticv1alpha1.ElasticJob {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/log"

elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
master "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/controllers/master"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
master "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/controllers/master"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,17 @@ package master
import (
"context"
"fmt"
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
"strconv"

elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
logger "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
runtime_client "sigs.k8s.io/controller-runtime/pkg/client"
"strconv"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,14 @@
package master

import (
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
"strings"
"testing"

elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
"github.com/stretchr/testify/assert"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"strings"
"testing"
)

func TestCreateMasterPod(t *testing.T) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ import (
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/predicate"

elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
logf "sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/log/zap"

elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
//+kubebuilder:scaffold:imports
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,19 @@ package training
import (
"context"
"fmt"
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
master "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/controllers/master"
logger "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
runtime_client "sigs.k8s.io/controller-runtime/pkg/client"
"sort"
"strconv"
"strings"
"time"

elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
master "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/controllers/master"
logger "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/errors"
runtime_client "sigs.k8s.io/controller-runtime/pkg/client"
)

const (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,16 @@ package training

import (
"encoding/json"
elasticv1alpha1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"
"testing"

elasticv1alpha1 "github.com/intelligent-machine-learning/dlrover/go/operator/api/v1alpha1"
common "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common"
commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
"github.com/stretchr/testify/assert"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
runtime_client "sigs.k8s.io/controller-runtime/pkg/client"
"testing"
)

func newTestJob() *elasticv1alpha1.ElasticJob {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ package training

import (
"encoding/json"
commonv1 "github.com/intelligent-machine-learning/easydl/dlrover/go/operator/pkg/common/api/v1"

commonv1 "github.com/intelligent-machine-learning/dlrover/go/operator/pkg/common/api/v1"
logger "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
)
Expand Down
Loading