Create master pod spec from the dlrover-master spec of elasticjob. #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingloong
requested review from
nash635,
samplise and
BalaBalaYi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1438 +/- ##
=======================================
Coverage 81.19% 81.19%
=======================================
Files 238 238
Lines 23169 23169
=======================================
Hits 18813 18813
Misses 4356 4356 ☔ View full report in Codecov by Sentry. |
samplise
merged commit f762e17
into
intelligent-machine-learning:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create master pod spec from the dlrover-master spec of elasticjob spec.
Why are the changes needed?
Fix #1432
Does this PR introduce any user-facing change?
Yes. Users can define the dlrover-master in the elasticjob.
How was this patch tested?
UT.