Add rule of elasticjobs/finalizers for the default role. #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingloong
requested review from
nash635,
samplise and
BalaBalaYi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
- Coverage 81.21% 81.16% -0.06%
==========================================
Files 238 238
Lines 23183 23183
==========================================
- Hits 18829 18817 -12
- Misses 4354 4366 +12 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
reviewed
Jan 20, 2025
BalaBalaYi
merged commit b0fc852
into
intelligent-machine-learning:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the update authorization of elasticjobs/finalizers for the default role.
Why are the changes needed?
Fix #1436
Does this PR introduce any user-facing change?
No.
How was this patch tested?
We can apply the yaml in a k8s cluster to verify it.