Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network check status report issue. #1447

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

  1. Use 'success' as flag to determine whether to use 'node-check failed' or 'node-check success' for reporting.
  2. Use a defined error 'NodeCheckFailedError' to distinguish 'failed' and 'node-check failed' reporting.

Why are the changes needed?

  1. Should return 'node-check success' if there is 1 round check which result is success.
  2. Should not use 'failed exited' status to override 'node-check failed' status if the node is failed by node-check.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Training with node check failed.

@BalaBalaYi BalaBalaYi added the bug Something isn't working label Jan 21, 2025
@BalaBalaYi BalaBalaYi added this to the v0.5.0 milestone Jan 21, 2025
@BalaBalaYi BalaBalaYi self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (e889a69) to head (a249fa4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/elastic_agent/torch/training.py 72.22% 5 Missing ⚠️
...lrover/python/tests/test_elastic_training_agent.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage   81.21%   81.41%   +0.19%     
==========================================
  Files         238      238              
  Lines       23183    23217      +34     
==========================================
+ Hits        18829    18901      +72     
+ Misses       4354     4316      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BalaBalaYi BalaBalaYi merged commit 17ab888 into intelligent-machine-learning:master Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants