Refactor failed node counter. #1450
Merged
+45
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_counter # Conflicts: # dlrover/python/elastic_agent/torch/training.py
BalaBalaYi
requested review from
workingloong,
samplise and
majieyue
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1450 +/- ##
==========================================
+ Coverage 81.39% 81.40% +0.01%
==========================================
Files 238 238
Lines 23217 23238 +21
==========================================
+ Hits 18897 18917 +20
- Misses 4320 4321 +1 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
merged commit 7a95974
into
intelligent-machine-learning:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use a dict to save fault node info in job context.
Node check failed should also be counted as 'failed worker'.
Why are the changes needed?
Bug fix: some worker failed is not counted.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Training with node check failed.