Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAD Analyzer, Closes #814 #2655

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

basedBaba
Copy link

@basedBaba basedBaba commented Jan 3, 2025

Description

WAD Analyzer, Closes #814

Type of change

  • New feature (non-breaking change which adds functionality).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • I strictly followed the documentation "How to create a Plugin"
    • Usage file was updated. A link to the PR to the docs repo has been added as a comment here.
    • Advanced-Usage was updated (in case the plugin provides additional optional configuration). A link to the PR to the docs repo has been added as a comment here.
    • I have dumped the configuration from Django Admin using the dumpplugin command and added it in the project as a data migration. ("How to share a plugin with the community")
    • If a File analyzer was added and it supports a mimetype which is not already supported, you added a sample of that type inside the archive test_files.zip and you added the default tests for that mimetype in test_classes.py.
    • If you created a new analyzer and it is free (does not require any API key), please add it in the FREE_TO_USE_ANALYZERS playbook by following this guide.
    • Check if it could make sense to add that analyzer/connector to other freely available playbooks.
    • I have provided the resulting raw JSON of a finished analysis and a screenshot of the results.
    • If the plugin interacts with an external service, I have created an attribute called precisely url that contains this information. This is required for Health Checks.
    • If the plugin requires mocked testing, _monkeypatch() was used in its class to apply the necessary decorators.
    • I have added that raw JSON sample to the MockUpResponse of the _monkeypatch() method. This serves us to provide a valid sample for testing.
  • If external libraries/packages with restrictive licenses were used, they were added in the Legal Notice section.
  • Linters (Black, Flake, Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

Important Rules

  • If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
  • Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review. After being reviewed and received a "change request", you should explicitly ask for a review again once you have made the requested changes.

Raw JSON :-

{
    "id": 1,
    "user": {
        "username": "admin"
    },
    "tags": [],
    "comments": [],
    "pivots_to_execute": [],
    "analyzers_to_execute": [
        "WAD"
    ],
    "analyzers_requested": [
        "WAD"
    ],
    "connectors_to_execute": [],
    "connectors_requested": [],
    "visualizers_to_execute": [],
    "playbook_requested": null,
    "playbook_to_execute": null,
    "investigation": null,
    "permissions": {
        "kill": true,
        "delete": true,
        "plugin_actions": true
    },
    "analyzers_data_model": [],
    "analyzer_reports": [
        {
            "name": "WAD",
            "process_time": 0.99,
            "status": "SUCCESS",
            "end_time": "2025-01-03T10:10:23.320556Z",
            "parameters": {},
            "type": "analyzer",
            "id": 1,
            "report": {
                "https://www.google.com/": [
                    {
                        "app": "Google Web Server",
                        "ver": null,
                        "type": "Web Servers"
                    }
                ]
            },
            "errors": [],
            "start_time": "2025-01-03T10:10:22.331197Z",
            "description": "[WAD](https://github.com/CERN-CERT/WAD) (Web Application Detector) lets you analyze given URL(s) and detect technologies used by web application behind that URL, from the OS and web server level, to the programming platform and frameworks, as well as server- and client-side applications, tools and libraries.",
            "data_model": {}
        }
    ],
    "connector_reports": [],
    "pivot_reports": [],
    "visualizer_reports": [],
    "is_sample": false,
    "md5": "8ffdefbdec956b595d257f0aaeefd623",
    "observable_name": "https://www.google.com",
    "observable_classification": "url",
    "file_name": "",
    "file_mimetype": "",
    "status": "reported_without_fails",
    "runtime_configuration": {
        "pivots": {},
        "analyzers": {},
        "connectors": {},
        "visualizers": {}
    },
    "received_request_time": "2025-01-03T10:10:22.151103Z",
    "finished_analysis_time": "2025-01-03T10:10:23.428837Z",
    "process_time": 1.28,
    "tlp": "AMBER",
    "errors": [],
    "warnings": [],
    "scan_mode": 2,
    "scan_check_time": "1 00:00:00"
}

Screenshot :-

image

@basedBaba basedBaba force-pushed the feat/wad branch 2 times, most recently from f61bf59 to ced47a7 Compare January 7, 2025 11:19
@basedBaba basedBaba marked this pull request as ready for review January 7, 2025 14:31
@basedBaba basedBaba requested a review from mlodic January 7, 2025 14:31
Copy link
Member

@mlodic mlodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would kindly ask you to adjust the migration number. Unluckily another PR has been merged before yours and they "stole" your migration numbers.

To do that, please pull from develop and then adjust your migration numbers, both file name and dependencies names. Then we'll merge this PR. Ty

@mlodic
Copy link
Member

mlodic commented Jan 7, 2025

@drosetti FYI merge this as the next PR after the migration numbers have been solved.

@basedBaba
Copy link
Author

I have adjusted the migration numbers

@basedBaba basedBaba requested a review from mlodic January 11, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants