-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAD Analyzer, Closes #814 #2655
base: develop
Are you sure you want to change the base?
Conversation
api_app/playbooks_manager/migrations/0058_add_wad_to_free_to_use.py
Outdated
Show resolved
Hide resolved
api_app/analyzers_manager/migrations/0144_analyzer_config_wad.py
Outdated
Show resolved
Hide resolved
f61bf59
to
ced47a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would kindly ask you to adjust the migration number. Unluckily another PR has been merged before yours and they "stole" your migration numbers.
To do that, please pull from develop
and then adjust your migration numbers, both file name and dependencies names. Then we'll merge this PR. Ty
@drosetti FYI merge this as the next PR after the migration numbers have been solved. |
I have adjusted the migration numbers |
Description
WAD Analyzer, Closes #814
Type of change
Checklist
develop
dumpplugin
command and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zip
and you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERS
playbook by following this guide.url
that contains this information. This is required for Health Checks._monkeypatch()
was used in its class to apply the necessary decorators.MockUpResponse
of the_monkeypatch()
method. This serves us to provide a valid sample for testing.Black
,Flake
,Isort
) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.tests
folder). All the tests (new and old ones) gave 0 errors.DeepSource
,Django Doctors
or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules
Raw JSON :-
Screenshot :-