clean up anti-pattern: move setPlaceholderType out of render to wil…

…lUpdate
internetarchive · Jan 4, 2024 · c7a3ed5 · c7a3ed5
1 parent 317b916
commit c7a3ed5
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/collection-browser.ts b/src/collection-browser.ts
@@ -420,7 +420,6 @@ export class CollectionBrowser
   }
 
   render() {
-    this.setPlaceholderType();
     return html`
       <div
         id="content-container"
@@ -995,6 +994,11 @@ export class CollectionBrowser
     this.restoreState();
   }
 
+  willUpdate() {
+    console.log('willUpdate');
+    this.setPlaceholderType();
+  }
+
   updated(changed: PropertyValues) {
     if (changed.has('placeholderType') && this.placeholderType === null) {
       if (!this.leftColIntersectionObserver) {