Unit Tests Updates #336
Merged
Unit Tests Updates #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nsharma123
reviewed
Jan 4, 2024
latonv
force-pushed
the
webdev6081-state-management
branch
from
c657f97 to
eb0d881
Compare
- this breaks View when dynamically toggling sort bar on an already loaded collection browser
latonv
force-pushed
the
resize-observer-loan-tab-fix
branch
from
f0b9733 to
e46fed6
Compare
latonv
added a commit
that referenced
this pull request
Jan 25, 2024
* Use hits/aggregations from page_elements branch if available * Rely on search service to handle page_element unpacking * Sort Bar Test - Ensure Resize Observer fires ONLY when needed - this breaks View when dynamically toggling sort bar on an already loaded collection browser * TESTS - Fix some, comment some out that need rework with the refactor - WEBDEV-6801 * Unskip a few tests that were fixed in the refactor branch * Uncomment a few more tests that have been fixed * Further test fixes * Fix last two remaining unit test failures --------- Co-authored-by: Laton Vermette <[email protected]>
latonv
added a commit
that referenced
this pull request
Jan 26, 2024
* Use hits/aggregations from page_elements branch if available * Rely on search service to handle page_element unpacking * Sort Bar Test - Ensure Resize Observer fires ONLY when needed - this breaks View when dynamically toggling sort bar on an already loaded collection browser * TESTS - Fix some, comment some out that need rework with the refactor - WEBDEV-6801 * Unskip a few tests that were fixed in the refactor branch * Uncomment a few more tests that have been fixed * Further test fixes * Fix last two remaining unit test failures --------- Co-authored-by: Laton Vermette <[email protected]>
latonv
added a commit
that referenced
this pull request
Jan 26, 2024
…UI (#330) * Create basic state management setup * Facet state refactoring to minimize repetition * Move facet refactor to different branch * First pass extracting CB data source into a reactive controller * Better abstraction for data source * Setup for reactive controller lifecycle * Top-level exports for data source * Remove obsolete state management stub * Build out some more robust interfaces for state management * Facet state adjustments * Facet state adjustments * Migrate tile mapping function into new data source * Add methods for tile mapping & check/unchecking to interface * Migrate tile mapping/checking methods into data source * Keep track of data source size * Adjust some cb methods to delegate to data source * Include data source size in interface * Minor adjustments to how cb retrieves cell models * Reorganize some properties * Request host updates from reactive controller * Fix some tests * Add script for quicker test running * Streamline models * Conform collection browser to search state model * Convert derived sortParam property into getter * Fix some breaking tests related to sortParam * Fix a model property naming issue * Connect up data source w/ cb query change handlers * Model updates for cb host * Migrate several fetch methods over to data source * Fix some convenience methods in cb * Try migrating some page fetching routines * Adjust search state model to accommodate page fetch * Migrate page fetching & related props into data source * Clean up cb a bit and delegate all remaining page fetches * Excise collection-name-cache in favor of data source map * Use basic map for collection titles (no need for specialized get behavior since everywhere it is used has a null-guard anyway) * Data source should not fetch facets when suppressed * Remove filterMap from search state interface (it's part of the datasource) * Cleanup to avoid passing data source around * Cleaning up some lingering details in cb * Migrate prefix filters over to data source * Improve data source documentation + general cleanliness * Remove a bit of dead code in cb * Fetch controller * Cleaner data types for page target params * Export TileModel interface * Use updated search service models * Ensure that profile pages are allowed to perform no-query searches * Add profile target to query keys * Ensure query change updates occur on profile target changes * Use hits/aggregations from page_elements branch if available * Rely on search service to handle page_element unpacking * Emit event for any query state changes * Add debug logging & fix result count bug * Fix broken test * Properly reset endOfDataReached upon query change * Fix a bug where checking tile in manage view doesn't work * Ensure result views are refreshed when checking/unchecking all in manage mode * Fix several unit tests * Fix bug where scroller tile count not being set correctly on short result sets * Unit Tests Updates (#336) * Use hits/aggregations from page_elements branch if available * Rely on search service to handle page_element unpacking * Sort Bar Test - Ensure Resize Observer fires ONLY when needed - this breaks View when dynamically toggling sort bar on an already loaded collection browser * TESTS - Fix some, comment some out that need rework with the refactor - WEBDEV-6801 * Unskip a few tests that were fixed in the refactor branch * Uncomment a few more tests that have been fixed * Further test fixes * Fix last two remaining unit test failures --------- Co-authored-by: Laton Vermette <[email protected]> * Pull some helper functions out into utils * Promote TileModel from a bare interface to a class, to better organize conversion from search results * Move reset method up for clarity * Move RequestKind into models file * Upgrade search service version & fix tests that use tile model * Fixes some display issues related to updated model structure & adding web capture links * Refactor data source installation & fix broken web archive images * Ensure data source only modifies host when it is attached * Unskip fixed tests * Do not rely on current host state for fetch invalidation, since it may be attached to a different data source * Apply loading states on host connect * Fix boolean flip bug on facet fetch * Apply correct default sorts for profile tabs * Ensure facets & date picker maintain the correct state when data source installed * Debug logging for page scroll issue * Add some missing unit tests * Additional unit tests & minor refactor for letter filter updates * Additional test fixes * Unit test for empty results case * Fix issues with letter filter bar & extra fetches * Clean up some debug logging * Upgrade search-service dependency * Upgrades search-service off alpha tag * Remove unused local-cache dependency * Small fix for web archive results beyond first page + tests --------- Co-authored-by: Isa Herico Velasco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<sort-filter-bar>: Resize Observer breaks when toggling between default view & custom slotted view<collection-browser>:removeCheckedItemsare not working as expected from unit test levelplaceholderTypenot setting properly