Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable problematic requirements only on Python 3 #1693

Merged
merged 4 commits into from
Dec 10, 2018
Merged

Disable problematic requirements only on Python 3 #1693

merged 4 commits into from
Dec 10, 2018

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Dec 8, 2018

This issue is directly related to #1679, #1680, #1638, #1694, #1687 and indirectly related to #1522 and #1634.

Certain Python dependencies do not currently have an acceptable Python 3 equivalent and they block our Travis CI build process in the install step. This PR proposes to use the conditional capabilities of requirements.txt files to only install these modules on legacy Python and not install them on Python. This should allow us to get past the install step and start running our PyTests.

$ pip install -r requirements_test.txt

Ignoring Genshi: markers 'python_version < "3.0"' don't match your environment
Ignoring iptools: markers 'python_version < "3.0"' don't match your environment
Ignoring supervisor: markers 'python_version < "3.0"' don't match your environment
Ignoring OL-GeoIP: markers 'python_version < "3.0"' don't match your environment
Ignoring mockcache: markers 'python_version < "3.0"' don't match your environment

@cclauss cclauss changed the title Disable problematic requirements on Python 3 Disable problematic requirements only on Python 3 Dec 9, 2018
@mekarpeles
Copy link
Member

I think this makes sense for now. We'll likely have to find alternatives for these packages in python3 eventually

@mekarpeles mekarpeles merged commit 7f31bd9 into internetarchive:master Dec 10, 2018
@cclauss cclauss deleted the requirements-files branch December 10, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants