Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Python 3 integration branch #2888

Closed
wants to merge 48 commits into from
Closed

WIP: Python 3 integration branch #2888

wants to merge 48 commits into from

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Jan 20, 2020 •
edited
Loading

Fixes: #2889

Cherry-picked from #2416

Corresponds to the suggestion at #2416 (comment)

Closes #

Technical

Testing

Evidence

Stakeholders

@cclauss
from web.browser import AppBrowser
d46bd94 
Cherry-picked from #2416

Corresponds to the suggestion at #2416 (comment)
@tfmorris
Copy link
Contributor

Are you abandoning #2416? I thought it was ready to go.

Now it seems like this is redoing the work in #2887 but I haven't done a complete analysis to see if one or the other is a superset.

@cclauss
Copy link
Collaborator Author

cclauss commented Jan 20, 2020 •
edited
Loading

Are you abandoning #2416? I thought it was ready to go.

Nope but #2416 has been mired since Sep 27th in reviews so I am trying to fix the issues that arise if #2416 is ever resolved.

Now it seems like this is redoing the work in #2887

Sorry. I did not see that you had started #2887 a few hours earlier.

pytest output makes it clear that Python 3 progress is now blocked by:
#1486, #1694, #2416, #2866, #2879, #2889

@hornc hornc self-assigned this Jan 20, 2020
@cclauss
from openlibrary.plugins.upstream import utils
e859980
@cclauss
from openlibrary.plugins.upstream import spamcheck, utils
dc3b19f
@cclauss
import openlibrary.plugins.openlibrary.filters as stats_filters
f255414
@cclauss
from openlibrary.core.lists.model import ListMixin, Seed
c51ec0d
@cclauss
from openlibrary.plugins.upstream import borrow, forms, utils
5691d76
@cclauss
from openlibrary.plugins.worksearch import searchapi, subjects
2319895
@cclauss
from openlibrary.plugins.search import facet_hash, solr_client, stopword
48bd7ad
@cclauss
from openlibrary.plugins.openlibrary.libraries import LoanStats
750adf4
@cclauss
from six import StringIO
6af0ff8
@cclauss
from six import StringIO
aec8521
@cclauss
from six import StringIO
1a6e857
@cclauss
from six import StringIO
8411010
@cclauss
from openlibrary.plugins.importapi import import_edition_builder
ab50837
@cclauss
Update import_rdf.py
48b5ebf
@cclauss
from openlibrary.plugins.importapi.import_edition_builder import impo…
27886df 
…rt_edition_builder
@tfmorris tfmorris mentioned this pull request Jan 21, 2020
Closed
@cclauss cclauss mentioned this pull request Jan 23, 2020
Closed
@cclauss cclauss changed the title from web.browser import AppBrowser WIP: Python 3 integration branch Jan 28, 2020
@cclauss cclauss mentioned this pull request Feb 1, 2020
Closed
@cclauss
Copy link
Collaborator Author

cclauss commented Feb 12, 2020

Closing in favor of #3016

@cclauss cclauss closed this Feb 12, 2020
@cclauss cclauss deleted the from-web.browser-import-AppBrowser branch February 12, 2020 04:13
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Module: Python labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hornc hornc Awaiting requested review from hornc

@tfmorris tfmorris Awaiting requested review from tfmorris

@mekarpeles mekarpeles Awaiting requested review from mekarpeles

Assignees

@hornc hornc

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MutableMapping is not a 100% replacement for DictMixin
4 participants
@cclauss @tfmorris @hornc @mekarpeles