Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dependabot python checks until we stabilise #2904

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

hornc
Copy link
Collaborator

@hornc hornc commented Jan 22, 2020

closes #2878

We know a large portion of our Python modules are out of date, and that some of them are not even used for current functionality.
Manual review and fixing of the versions that are causing active problems is required at this stage. Currently minor point version updates are more difficult and risky than they should be, if there is not an active reason to update a module, we shouldn't at this stage.

Removing some out of date unused dependencies is preferable to keeping them current without understanding how we use them, e.g.
#2896

When we remove what is not needed and get to a stable point with Python 3, we can re-enable this tool.

Closes #

Technical

Testing

Evidence

Stakeholders

@cclauss
Copy link
Collaborator

cclauss commented Jan 22, 2020

#-style comments work just fine in .yml files and that might be a safer approach given that these are temporary changes that we plan to undo.

closes #2878

We know a large portion of our Python modules are out of date, and that some of them are not even used for current functionality.
Manual review and fixing of the versions that are causing active problems is required at this stage. Currently minor point version updates are more difficult and risky than they should be, if there is not an active reason to update a module, we shouldn't at this stage.

Removing some out of date unused dependencies is preferable to keeping them current without understanding how we use them, e.g.  #2896

When we remove what is not needed and get to a stable point with Python 3, we can re-enable this tool.
@hornc
Copy link
Collaborator Author

hornc commented Jan 22, 2020

@cclauss good idea, I have re-made the change by commenting out the lines rather than deleting. Thanks!

@hornc hornc merged commit 2bc16b0 into master Jan 23, 2020
@cclauss cclauss deleted the hornc-patch-3 branch January 23, 2020 03:04
@cclauss cclauss restored the hornc-patch-3 branch January 23, 2020 03:04
@hornc hornc deleted the hornc-patch-3 branch March 8, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependabot -- disable python checking, but re-enable it once we move to Python3 properly
2 participants