Make minio local only; add a speedup; make headless prod only #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Loftus
commented
Feb 6, 2025
| @@ -180,7 +182,7 @@ services: | |||
| - production | |||
|
|
|||
| # Headless browser for testing | |||
| headless: | |||
| scheduler_headless: | |||
There was a problem hiding this comment.
made service name match container name just for clarity; shouldnt change anything to my understanding
C-Loftus
commented
Feb 6, 2025
| @@ -492,7 +495,7 @@ def nabu_orgs_release(context: OpExecutionContext): | |||
|
|
|||
|
|
|||
| @asset(partitions_def=sources_partitions_def, deps=[nabu_orgs_release]) | |||
| def nabu_orgs(context: OpExecutionContext): | |||
| def nabu_orgs_prefix(context: OpExecutionContext): | |||
There was a problem hiding this comment.
added the word prefix to make it clear that the nabu prefix X command is being ran
C-Loftus
commented
Feb 6, 2025
| @@ -427,7 +430,7 @@ def nabu_prov_release(context): | |||
| ) | |||
|
|
|||
|
|
|||
| @asset(partitions_def=sources_partitions_def, deps=[nabu_prov_release]) | |||
| @asset(partitions_def=sources_partitions_def, deps=[gleaner]) | |||
There was a problem hiding this comment.
prov_clear clears the triplestore whereas prov_release generates a nq file but does not operate on the triplestore. Thus they can be done in parallel and are not dependent on each other
There was a problem hiding this comment.
graph looks like this now
C-Loftus
commented
Feb 6, 2025
| assert ( | ||
| len(Lines) > 0 | ||
| ), f"No sitemaps found in sitemap index {REMOTE_GLEANER_SITEMAP}" | ||
| assert len(Lines) > 0, f"No sitemaps found in index {REMOTE_GLEANER_SITEMAP}" |
There was a problem hiding this comment.
made this shorter since my local ruff formatted is different from ruff in precommit for some reason and messes with this if it is too long
webb-ben
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.