Skip to content

Commit

Permalink
disable fast reciprocal division in SIMD because it seems to make the…
Browse files Browse the repository at this point in the history
… final results worse
  • Loading branch information
paulbkoch committed Mar 31, 2024
1 parent 614b97a commit 9ca58ec
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion shared/libebm/unzoned/unzoned.h
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,11 @@ INLINE_ALWAYS static void StopClangAnalysis(void) EBM_NOEXCEPT ANALYZER_NORETURN
StopClangAnalysis(); \
} while((void)0, 0)

#define FAST_DIVISION
// Disable this for now. Using fast reciprocals seems to change the results quite a bit
// and make them worse. Also, the reciprocal algorithm is different between Intel and AMD
// and it makes comparisons difficult, and I don't think this division is critical to
// making it faster
//#define FAST_DIVISION

// 16 byte alignment works for *most* SIMD implementation, but it's even better to align with the 64 byte cache!
#define SIMD_BYTE_ALIGNMENT STATIC_CAST(size_t, 64)
Expand Down

0 comments on commit 9ca58ec

Please sign in to comment.